Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty auth config required for authentication-less private registries #102

Closed
jgangemi opened this issue Feb 19, 2015 · 1 comment
Closed
Labels
Milestone

Comments

@jgangemi
Copy link
Collaborator

the following is required to push images to a private registry that doesn't require authentication

<authConfig>
  <username></username>
  <password></password>
</authConfig>

which is kind of ugly and seems needless.

i thought about attempting to check if a registry has been specified and if yes but no authConfig block was found, build the empty config and use that but i'm unsure if there could be other implications from that.

i also thought about adding some kind if 'insecure' tag but that doesn't seem worth the work given it's one field replacing two and i could just as easily do this

<authConfig>
  <username>n/a</username>
  <password>n/a</password>
</authConfig>

thoughts? this may be an edge case given most registries will be secured in some manner, but maybe not.

@jgangemi
Copy link
Collaborator Author

inquired if it's safe to always send an empty encoded X-Registry-Auth in moby/moby#10983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants