Add support of docker multi stage builds

[KeZiio]

This PR adds support of docker multi stage builds using Dockerfile.
See https://docs.docker.com/develop/develop-images/multistage-build/ for feature description.

[codecov]

Codecov Report

Merging #1057 into master will increase coverage by 0.29%.
The diff coverage is 52.94%.

@@             Coverage Diff              @@
##             master    #1057      +/-   ##
============================================
+ Coverage     51.98%   52.27%   +0.29%     
+ Complexity     1486     1405      -81     
============================================
  Files           150      147       -3     
  Lines          7951     7566     -385     
  Branches       1192     1149      -43     
============================================
- Hits           4133     3955     -178     
+ Misses         3412     3233     -179     
+ Partials        406      378      -28

Impacted Files	Coverage Δ	Complexity Δ
.../io/fabric8/maven/docker/service/BuildService.java	63.15% <40%> (+34.48%)	18 <0> (+9)	⬆️
...a/io/fabric8/maven/docker/util/DockerFileUtil.java	79.54% <71.42%> (+9.7%)	13 <1> (-4)	⬇️
...abric8/maven/docker/service/ServiceHubFactory.java	0% <0%> (-80%)	0% <0%> (-2%)
...va/io/fabric8/maven/docker/service/ServiceHub.java	0% <0%> (-36.59%)	0% <0%> (-3%)
...java/io/fabric8/maven/docker/VolumeCreateMojo.java	0% <0%> (-30%)	0% <0%> (-2%)
...java/io/fabric8/maven/docker/VolumeRemoveMojo.java	0% <0%> (-30%)	0% <0%> (-2%)
...o/fabric8/maven/docker/service/ArchiveService.java	0% <0%> (-26.67%)	0% <0%> (-1%)
...a/io/fabric8/maven/docker/service/WaitService.java	0% <0%> (-4.24%)	0% <0%> (-1%)
...va/io/fabric8/maven/docker/service/RunService.java	47.96% <0%> (-4.16%)	22% <0%> (-3%)
.../io/fabric8/maven/docker/service/WatchService.java	0% <0%> (-3.8%)	0% <0%> (-1%)
... and 48 more

[ghost]

Do not forget to remove this deprecated code someday.

[ghost]

SonarQube analysis reported 1 issue

• 1 info

Watch the comments in this conversation to review them.

[rhuss]

Thanks a lot ! The PR looks good, but could you please elaborate a bit why mutlti stage builds would make sense in the context of d-m-p ? Do you have concrete use case ?

[KeZiio]

Hi, @rhuss

Do you have concrete use case ?

I faced it when started mysql container for integration test with fixtures. So Dockerfile looks like next:

ARG FIXTURE_VERSION
FROM mysql-fixture-base:5.6-${FIXTURE_VERSION}
# This images uses ONBUILD instructions that are run at this point
# This delayed execution is necessary to configure database 
# (i.e. user/pass and schema) and ADD fixture files from the child image.

# Start from a clean MySQL image
FROM mysql:5.6
#
# Some Copy instruction to keep only DB related files

In turn mysql-fixture-base:5.6 is created in separate pipeline using Dockerfile like:

# standalone application that patches db
FROM patcher

FROM mysql:5.6

# Some COPY and RUN instruction to patch DB

But when i run my test i want to get rid of intermediate fixture files and patcher application so that image become more lightweight.

[rhuss]

I'm fine with the change, let's merge it.