Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'autoRemove' option #1179

Merged
merged 3 commits into from
Apr 5, 2019
Merged

Added 'autoRemove' option #1179

merged 3 commits into from
Apr 5, 2019

Conversation

bgutjahr
Copy link
Contributor

Added 'autoRemove' option to run configuration to automatically remove a container when it exits (like docker run --rm).
This is needed to make sure that a container will be removed after exit even if the maven process is killed before it could stop the container.

…e a container when it exits (like docker run --rm)
@rohanKanojia rohanKanojia requested a review from rhuss March 26, 2019 07:45
@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #1179 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1179      +/-   ##
============================================
+ Coverage     52.32%   52.35%   +0.03%     
+ Complexity     1479     1476       -3     
============================================
  Files           150      150              
  Lines          7882     7862      -20     
  Branches       1175     1170       -5     
============================================
- Hits           4124     4116       -8     
+ Misses         3354     3343      -11     
+ Partials        404      403       -1
Impacted Files Coverage Δ Complexity Δ
...va/io/fabric8/maven/docker/service/RunService.java 52.11% <100%> (+0.2%) 25 <0> (ø) ⬇️
...aven/docker/config/handler/property/ConfigKey.java 100% <100%> (ø) 10 <0> (ø) ⬇️
...ic8/maven/docker/config/RunImageConfiguration.java 91.19% <100%> (+0.16%) 51 <1> (+1) ⬆️
...config/handler/property/PropertyConfigHandler.java 74.44% <100%> (ø) 117 <0> (ø) ⬇️
...bric8/maven/docker/access/ContainerHostConfig.java 85.29% <100%> (+0.14%) 41 <1> (+1) ⬆️
...8/maven/docker/config/BuildImageConfiguration.java 82.2% <0%> (-0.43%) 60% <0%> (-1%)
...bric8/maven/docker/assembly/DockerFileBuilder.java 90.33% <0%> (-0.41%) 77% <0%> (-4%)
.../java/io/fabric8/maven/docker/model/Container.java 100% <0%> (ø) 0% <0%> (ø) ⬇️
... and 5 more

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #1179 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1179      +/-   ##
============================================
+ Coverage     52.32%   52.35%   +0.03%     
+ Complexity     1479     1476       -3     
============================================
  Files           150      150              
  Lines          7882     7862      -20     
  Branches       1175     1170       -5     
============================================
- Hits           4124     4116       -8     
+ Misses         3354     3343      -11     
+ Partials        404      403       -1
Impacted Files Coverage Δ Complexity Δ
...va/io/fabric8/maven/docker/service/RunService.java 52.11% <100%> (+0.2%) 25 <0> (ø) ⬇️
...aven/docker/config/handler/property/ConfigKey.java 100% <100%> (ø) 10 <0> (ø) ⬇️
...ic8/maven/docker/config/RunImageConfiguration.java 91.19% <100%> (+0.16%) 51 <1> (+1) ⬆️
...config/handler/property/PropertyConfigHandler.java 74.44% <100%> (ø) 117 <0> (ø) ⬇️
...bric8/maven/docker/access/ContainerHostConfig.java 85.29% <100%> (+0.14%) 41 <1> (+1) ⬆️
...8/maven/docker/config/BuildImageConfiguration.java 82.2% <0%> (-0.43%) 60% <0%> (-1%)
...bric8/maven/docker/assembly/DockerFileBuilder.java 90.33% <0%> (-0.41%) 77% <0%> (-4%)
.../java/io/fabric8/maven/docker/model/Container.java 100% <0%> (ø) 0% <0%> (ø) ⬇️
... and 5 more

Copy link
Collaborator

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks a lot !

@rhuss rhuss merged commit b59d575 into fabric8io:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants