Implemented authentication via EC2 instance role for ECR #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1186 +/- ##
============================================
- Coverage 52.27% 52.06% -0.21%
Complexity 1484 1484
============================================
Files 150 150
Lines 7906 7934 +28
Branches 1183 1185 +2
============================================
- Hits 4133 4131 -2
- Misses 3369 3397 +28
- Partials 404 406 +2
|
rhuss
requested changes
Apr 5, 2019
|
|
||
| // read instance role | ||
| try (InputStream is = response.getEntity().getContent()) { | ||
| instanceRole = IOUtils.toString(is, StandardCharsets.UTF_8); |
There was a problem hiding this comment.
any validation of this instance role needed ?
There was a problem hiding this comment.
What exactly do you mean with "validation" in this context?
|
|
||
| // get temporary credentials | ||
| request = new HttpGet( | ||
| "http://169.254.169.254/latest/meta-data/iam/security-credentials/" + instanceRole); |
There was a problem hiding this comment.
URL encoding required as instanceRole is an externally (aka 'tainted') data ?
sithmein
force-pushed
the
support-for-ec2-instance-roles
branch
from
4a54859
to
68b0bf9
Compare
rhuss
requested changes
Apr 6, 2019
| try (InputStream is = response.getEntity().getContent()) { | ||
| instanceRole = IOUtils.toString(is, StandardCharsets.UTF_8); | ||
| } | ||
| } |
There was a problem hiding this comment.
formatting seems to be messed up a bit
sithmein
force-pushed
the
support-for-ec2-instance-roles
branch
from
68b0bf9
to
ebed8a6
Compare
sithmein
force-pushed
the
support-for-ec2-instance-roles
branch
from
ebed8a6
to
2261002
Compare
rhuss
approved these changes
Apr 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for EC2 instance roles as described in issue #1177.
I didn't add any tests since they would only work when run on a correctly configured EC2 instance.