Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do port/parameter substitution in environment variables #137

Merged
merged 4 commits into from
May 15, 2015

Conversation

sverhagen
Copy link
Contributor

I had a need for port/parameter substitution in environment variables. I wanted to set the database URL on my second container, that had the port as determined for the first container.

E.g., the second container had something like this:

<env>
    <DATABASE_URL>jdbc\:mysql\://${env.DOCKER_HOST_HOST}:${database.port}/</DATABASE_URL>
</env>

The code in the merge request does this, plus a few minor other snippets.

@sverhagen
Copy link
Contributor Author

Added the sign off as required here. Is there anything else I could do to move this forward? Thank you.

@rhuss
Copy link
Collaborator

rhuss commented Apr 8, 2015

I will have a look at it ASAP (probably at the end of this week). I think its a quite nice feature, so you can be pretty sure that the PR will be applied after a review.

@rhuss rhuss added this to the 0.11.4 milestone May 15, 2015
rhuss added a commit that referenced this pull request May 15, 2015
…ugin into 137-env-subst

Changed also string substitution to commons-lang3 to reduce DIH symptoms. The substitution is complex enough to justify the usage of this library. Fixes #137.
rhuss added a commit that referenced this pull request May 15, 2015
@rhuss
Copy link
Collaborator

rhuss commented May 15, 2015

Sorry for the delay. Applied the PR to integration, will be available in 0.11.4 soon.

@rhuss rhuss added the applied label May 15, 2015
@rhuss rhuss merged commit 92a2eae into fabric8io:master May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants