Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output to dir is now an archive. #139

Merged
merged 3 commits into from
May 15, 2015
Merged

Output to dir is now an archive. #139

merged 3 commits into from
May 15, 2015

Conversation

efollea
Copy link
Contributor

@efollea efollea commented Apr 6, 2015

The temporary assembly is now outputdir/build/maven.tgz instead of a directory (was outputdir/build/maven/

Aim to fix the files/directory rights defined in assembly issue which appear for some windows users.
The problem is that the fat/ntfs or any other file systeme like this ones which does not support linux like rights)
The solution is to use a system that does not rely on underling File system. choosen to use tgz archive.

Fixed some unit test issues under windows.

@efollea
Copy link
Contributor Author

efollea commented Apr 6, 2015

Dockerfile in outputdir should not be used when dockerFileDir is used, and a Dockerfile is present.

@efollea efollea closed this Apr 6, 2015
@efollea efollea reopened this Apr 6, 2015
@efollea
Copy link
Contributor Author

efollea commented Apr 6, 2015

Dockerfile in outputdir should not be used when dockerFileDir is used, and a Dockerfile is present.

taken from previous branch
@efollea
Copy link
Contributor Author

efollea commented Apr 8, 2015

this is a proposal for bug file permissions not set when 'fileMode' set in assembly descriptor #51

@rhuss
Copy link
Collaborator

rhuss commented May 15, 2015

Thanks, applied it finally (sorry for the long delay). Using a tar as intermediate format is also nice so that arbitray files in the output dir does not end up in the image by accident. Will be in 0.11.4

@rhuss rhuss added the applied label May 15, 2015
rhuss added a commit that referenced this pull request May 15, 2015
See #139 for details. Should fix #51 as well.
@rhuss rhuss merged commit 83b793e into fabric8io:master May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants