Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From field is required, even when setting dockerFileDir #201

Closed
oferrero opened this issue Jun 23, 2015 · 1 comment
Closed

From field is required, even when setting dockerFileDir #201

oferrero opened this issue Jun 23, 2015 · 1 comment
Milestone

Comments

@oferrero
Copy link

When using a dockerFileDir, the Dockerfile within that directory is to be used as the base image, and the from field is basically ignored. However, if one proceeds to remove the from field, the following error is received:

Caused by: org.apache.maven.plugin.MojoExecutionException: No image 'busybox:latest' found
    at org.jolokia.docker.maven.AbstractDockerMojo.checkImageWithAutoPull(AbstractDockerMojo.java:387)
    at org.jolokia.docker.maven.BuildMojo.buildImage(BuildMojo.java:83)
    at org.jolokia.docker.maven.BuildMojo.executeInternal(BuildMojo.java:70)
    at org.jolokia.docker.maven.AbstractDockerMojo.execute(AbstractDockerMojo.java:135)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)

Basically, the from field should be optional when setting the dockerFileDir.

@rhuss
Copy link
Collaborator

rhuss commented Jun 26, 2015

You are right, that's a bug.

@rhuss rhuss added the bug label Jun 26, 2015
@rhuss rhuss added this to the 0.12.1 milestone Jul 1, 2015
@rhuss rhuss added the fixed label Jul 3, 2015
@rhuss rhuss modified the milestones: 0.12.1, 0.13.0 Jul 3, 2015
@rhuss rhuss closed this as completed in fd325bc Jul 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants