Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logconfig option to write logs to specified file #287

Closed
wants to merge 1 commit into from

Conversation

ntrvic
Copy link

@ntrvic ntrvic commented Sep 16, 2015

We are using this plugin at Conductor and would really benefit from this addition. This PR will allow the user to pass the 'file' log configuration option for a given image and specify a location for the logs to be written to. For example:

<log>
    <file>${basedir}/app.out</file>
</log>

If the file option is empty, it will print to System.out, otherwise it will use FileOutputStream and print to the specified location.

Signed-off-by: Victor Gdalevich <gdalevichv@gmail.comm>

spacing

spacing

spacing
rhuss added a commit that referenced this pull request Sep 23, 2015
* No color if logging to a file
* Append to file (user must rotate on its own)
* Add documentation
* Refactoring (the map holding the streams is not needed)
* Add a property `docker.logStdout` to overwrite any configured file (useful when doing a `docker:log`)
@rhuss
Copy link
Collaborator

rhuss commented Sep 23, 2015

Thanks !

If you don't mind, I'm just polished it a bit:

  • No color if logging to a file
  • Append to file (user must rotate on its own)
  • Add documentation
  • Refactoring (the map holding the streams is not needed)
  • Add a property docker.logStdout to overwrite any configured file (useful when doing a docker:log)

@rhuss
Copy link
Collaborator

rhuss commented Sep 23, 2015

Will be available in the next release.

@rhuss rhuss closed this Sep 23, 2015
leusonmario pushed a commit to leusonmario/docker-maven-plugin that referenced this pull request Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants