Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support docker:watch correlating maven jars that end up in it's assem… #288

Closed
wants to merge 1 commit into from

Conversation

chirino
Copy link
Contributor

@chirino chirino commented Sep 16, 2015

…bly dir so that a docker container update can be triggered if transitive dep jar is installed in the mvn local repo.

Mostly a proof of concept. Using this dev:watch works on hawt-app based assemblies.

…bly dir so that a docker container update can be triggered if transitive dep jar is installed in the mvn local repo.
@rhuss
Copy link
Collaborator

rhuss commented Sep 18, 2015

Awesome, thanks, Hiram ! I will look at it ASAP (today, hopefully) ....

btw, do you have any comments on #284, #283 or #285 ? I really want to solve our gordian knot asap, not necessarily by implementing these features (although they would be a solution for the offline use case).

@rhuss
Copy link
Collaborator

rhuss commented Sep 21, 2015

I had a look at the PR:

  • The extraction for the maven coordinates is quite smart, like it :)
  • However: Dependencies in the Maven assembly are already have the local repository path as source. I guess you had an other use case in mind where you need to find out this path on your own (i.e. not jar dependencies)
  • For the artefact of this pom.xml, I think it is not needed to watch the repository variant but the one created in target/ (so that a mvn package would also trigger a rebuild)

Some improvement coming to mind, too:

  • We could ignore all non SNAPSHOT dependencies from watching, or ? That would speed up things a bit.
  • I injected the local repository directly into the tracker (via a session) so no need to pass it down as argument (done).

I will refactor the PR a bit (have seen some redundant directory name movememnt, too) and merge it into branch integration so we can continue from there on.

rhuss added a commit that referenced this pull request Sep 23, 2015
@rhuss
Copy link
Collaborator

rhuss commented Sep 23, 2015

I merged the changes in by hand. thanks again.

@rhuss rhuss closed this Sep 23, 2015
@chirino
Copy link
Contributor Author

chirino commented Sep 23, 2015

cool looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants