Wrong docker file being used with multiple images created.

[philnate]

Hi,

we have an issue with the plugin pulling in wrong Dockerfiles. We create a base image within the default profile, which is later on used within -P docker profile for other images. But somehow the first image within the docker profile will be created using the parent image Dockerfile rather than it's own. Adding an empty to the list seems to cure this behaviour. Version used is 0.13.7

    <build>
        <plugins>
            <plugin>
                <groupId>org.jolokia</groupId>
                <artifactId>docker-maven-plugin</artifactId>
                <configuration>
                <skipTags>true</skipTags>
                <logDate>default</logDate>
                <images>
                    <image>
                        <alias>base</alias>
                        <name>registry/base</name>
                        <build>
                            <assembly>
                                <dockerFileDir>jre</dockerFileDir>
                            </assembly>
                        </build>
                    </image>
                </images>
                </configuration>
                <executions>
                    <execution>
                        <id>build-images</id>
                        <phase>package</phase>
                        <goals>
                            <goal>build</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>
        </plugins>
    </build>

    <profiles>
        <profile>
            <id>docker</id>
            <build>
                <plugins>
                    <plugin>
                        <groupId>org.jolokia</groupId>
                        <artifactId>docker-maven-plugin</artifactId>
                        <configuration>
                            <skipTags>true</skipTags>
                            <logDate>default</logDate>
                            <images>
                                <!--add this to fix the issue-->
                                <!--<image></image>-->
                                <image>
                                    <name>registry/one</name>
                                    <build>
                                        <from>registry/base</from>
                                        <assembly>
                                            <mode>zip</mode>
                                            <basedir>/opt</basedir>
                                            <descriptor>one.xml</descriptor>
                                        </assembly>
                                        <cmd>
                                            <shell>some shell</shell>
                                        </cmd>
                                    </build>
                                </image>
                                <image>
                                    <name>registry/two</name>
                                    <build>
                                        <from>registry/base</from>
                                        <assembly>
                                            <mode>zip</mode>
                                            <basedir>/opt</basedir>
                                            <descriptor>two.xml</descriptor>
                                        </assembly>
                                        <cmd>
                                            <shell>some shell</shell>
                                        </cmd>
                                    </build>
                                </image>
                            </images>
                        </configuration>
                        <executions>
                            <execution>
                                <id>build-images</id>
                                <phase>package</phase>
                                <goals>
                                    <goal>build</goal>
                                </goals>
                            </execution>
                        </executions>
                    </plugin>
                </plugins>
            </build>
        </profile>

[jgangemi]

i believe this is the opposite problem described in #360 and using combine.self="override" should fix the problem.

see here: https://maven.apache.org/pom.html under the plugins section.

[philnate]

@jgangemi that seems to do the trick. Moving the other base image creation into it's own profile seems to work too. But what I don't get is, why does this affect only the first image and not the other one as well? Assuming that all nodes are merged together (index wise), this means that the base config gets merged into the first image of docker profile. And

<assembly>
             <dockerFileDir>jre</dockerFileDir>
</assembly>

takes precendence over the other configuration. Is this about right?

[jgangemi]

it has something to do w/ the way maven merges the pom configurations but i can't really give a more in-depth explanation then that.

when it does the merge, whatever is missing from the parent gets pulled from the child.

http://blog.sonatype.com/2011/01/maven-how-to-merging-plugin-configuration-in-complex-projects/#.Vo1lD8qEBmM

http://blog.sonatype.com/2007/06/how-to-merge-sub-items-from-parent-pom-to-child-pom-in-a-maven-plugin-configuration-2/#.Vo1lHcqEBmM

[philnate]

As this is no issue with the plugin, closing the ticket.