Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- initial docker-compose support #384

Closed
wants to merge 1 commit into from

Conversation

jgangemi
Copy link
Collaborator

now from the correct repository... :)

Signed-off-by: Jae Gangemi jgangemi@gmail.com

Signed-off-by: Jae Gangemi <jgangemi@gmail.com>
@jgangemi
Copy link
Collaborator Author

ugh - i feel like this poor thing is languishing...

@rhuss
Copy link
Collaborator

rhuss commented Mar 22, 2016

No, not really ;-) I'm already integrating it, however was stuck with some other work. Little by little, the bird builds its nest ...

@rhuss rhuss added the feature label Mar 22, 2016
@jgangemi
Copy link
Collaborator Author

that's wonderful news! sorry i've been more or less missing in action, i just haven't been able to find any free time to devote here which makes me sad b/c i love this project. hopefully soon though b/c we are starting to use the plugin more and more at the day job.

@rhuss rhuss mentioned this pull request Mar 23, 2016
@slamp
Copy link

slamp commented Jun 6, 2016

We would like to generate docker-compose.yml. Any idea when you can close this ?

@fusesource-ci
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@fusesource-ci
Copy link
Contributor

Can one of the admins verify this patch?

@jgangemi
Copy link
Collaborator Author

jgangemi commented Jun 8, 2016

what ever happened w/ this?

@rhuss
Copy link
Collaborator

rhuss commented Jun 9, 2016

the bird was tired :). not forgotten, just late. the Duke-Nukem-forever PR, sorry. I won't get into it before the end of the month because of having to give some talks and going to conferences next week.

but the pr bubbles up in my prio list. please keep poking me ....

sorry.

rhuss added a commit that referenced this pull request Jun 27, 2016
Was a bit of a work because package has been renamed in the meantime to io.fabric8.
Also started to restructure the config handling to be more flexible and extensible for new config handlers.

The test are not yet running because the juse mockito which has been removed in the meantime. We are using jmockit as unique Mocking framework now.

Story to be continued ...
rhuss added a commit that referenced this pull request Jun 27, 2016
Was a bit of a work because package has been renamed in the meantime to io.fabric8.
Also started to restructure the config handling to be more flexible and extensible for new config handlers.

The test are not yet running because the juse mockito which has been removed in the meantime. We are using jmockit as unique Mocking framework now.

Story to be continued ...
@rhuss
Copy link
Collaborator

rhuss commented Jun 27, 2016

@jgangemi next baby step. No, its a bigger one: I just rebased it to the current branch (was a bit of a work because package names has changed). And did some adaptions. Test are not yet running because I remove one (of two) mocking frameworks, and this was Mockito ;-) (using jmockit right now).

One thought about the 'extended' configuration for stuff which is not available in the compose file. I'd like to avoid reusing the existing image configuration for this as a background objects, because thats becomes too complex and you dont know which part of the ImageConfiguration is in effect and which not (most of it).

My ideal solution would be to 'extend' docker-compose.yml about the things we have in addition. Hopefully this is possible (so that compose ignores our stuff). If this is not possible, then we add the extra stuff as key-value pairs in the configuration. I want to keep the external configuration configuration :-) as plain as possible, without nested structures so that it is kept 'slim'.

I pushed my changes to branch 384-docker-compose, would be cool if we work on this for the future, so that I'm closing this PR for now.

@rhuss rhuss closed this Jun 27, 2016
@jgangemi
Copy link
Collaborator Author

meh, i find jmockit to be overly confusing compared to mockito but i guess i'll have to get over that. :)

being able to extend docker-compose.yml sounds interesting. i thought compose supported inheritance last i checked. if so, that could be one way to add plugin configuration to the yaml.

if we assume it's not possible to augment the compose file, how do you propose handling lists? i guess there is the option of the .1, .2... identifiers like the properties file uses but i'm not a huge fan of that. what about a separate configuration block that just has the fields applicable to compose? i realize you want to keep things slim but that does seem limiting at the same time.

i'll try and take a look in the coming days - i have some sprint work slated at the day job based around the plugin.

rhuss added a commit that referenced this pull request Oct 26, 2016
Signed-off-by: Roland Huß <roland@ro14nd.de>
rhuss added a commit that referenced this pull request Oct 26, 2016
Signed-off-by: Roland Huß <roland@ro14nd.de>
rhuss added a commit that referenced this pull request Oct 26, 2016
- Introduced a DeepCopy which can be used to initialize builders
- Worked on the docs

Signed-off-by: Roland Huß <roland@ro14nd.de>
@slamp
Copy link

slamp commented Nov 9, 2016

Thanks a lot for that. I hope I will be able to test it soon. We are using 0.16.2 for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants