-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for specifying local bind address #39
Conversation
- cleaned up compiler warnings - swapped test args so it's 'expected/actual'
Thanks a lot! I'm currently on vacations and will be back in a week. When I'm back I'll review the pull request ASAP. |
welcome! question as i'd like to contribute some more functionality... how tied are you to using the |
I intentionally decided against using a Java access library. Typically this is not the proper way but since Docker is moving so fast it is better to have less dependencies. I.e. it took quite some time for Also, I need only a fraction of the possibilities offered by the Docker remote API and the 'heavy lifting' is not so heavy (yet). And finally in order to fully control remote API's chunked encoding and streaming (e.g. for providing a progress bar) I need low-level access anyways. So, in order to answer your question: Yes, I'm tied to using a low-level (direct) API ;-) What kind of functionality do you have in mind ? |
Added it to 0.10.x and did some refactorings on the way. |
sorry for the late response, i was away myself... aside from naming the container (which is a query param anyway), i'm not entirely sure what other functionality just yet. i've only started using the plugin but i'm going to want to be able to do push button deploys, etc out of jenkins and just wanted to get a sense of your general plan should more of that heavy lifting become necessary. also - did this make it into master? i don't see the changes. |
Sorry, forgot to push yesterday evening. I moved the We need still to update the documentation (in the README.md, section |
Bump version of findbugs to 3.0.0
adds the ability to specify what ip address the container should bind to, eg:
i want to use the plugin to do actual deployments into docker and have a use case where an app needs to listen on a separate interface, so i need to be able to specify an ip.
it also cleans up some compiler warnings and swaps the test ares so they are 'expected/actual' :)