Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating of custom Networks during the start and delete during the stop #482

Closed
wants to merge 1 commit into from
Closed

Conversation

bohmber
Copy link
Contributor

@bohmber bohmber commented Jun 13, 2016

Default of createCustomNetworks is now false. No issues with existing networks.
Apply your small suggestions.

I need some advise how to create some unit tests

@rhuss
Copy link
Collaborator

rhuss commented Jun 13, 2016

thanks a lot ! I'm at conferences this week, but will have a look at the PR soon when I'm back (or maybe if I have some spare time then even this week ;-)

@rhuss
Copy link
Collaborator

rhuss commented Jun 26, 2016

Thanks for the PR. I polished it a bit and merged it to the integration branch so that it will end up in the next release.

/wrt unit test: They are quite a bit hard to write, so I suggest that you create a small sample project in samples/ which show the usage of a custom network. Maybe a simple java service calling a mysql db or sth. like that. That would be awesome. Please open a new PR for this since I'm going to close this.

Thank a lot !

@rhuss rhuss closed this Jun 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants