Add custom network IP address property mappings #533
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds property mappings for custom networks, using the format:
It seems important when the build is running on a container, and tries to start other containers in order to use them as remote services for integration testing. In this case, the only way I've found success is by using a custom network created using:
My Jenkins instance is running in its own docker container, so the bridge aspect allows me access to Jenkins. All the docker containers started by Jenkins will also need to use this custom network, I've found, and when the build needs to access them it can use the container's IP address on the custom network along with the ports from the EXPOSE line in the Dockerfile (not mapped ports).
This works for me, but I'm not sure I understand how to write tests for the patch I'm submitting. I've tried to match code formatting, but ended up just guessing at the rules. Please let me know if I've missed something that needs attention.