Allow comma separated list of container names in dependsOn elements #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #810 +/- ##
=========================================
Coverage 47.52% 47.52%
Complexity 1069 1069
=========================================
Files 134 134
Lines 6923 6923
Branches 910 910
=========================================
Hits 3290 3290
Misses 3351 3351
Partials 282 282
|
rhuss
reviewed
Jul 10, 2017
| @@ -97,7 +97,7 @@ private void addVolumes(RunImageConfiguration runConfig, List<String> ret) { | |||
|
|
|||
| private void addLinks(RunImageConfiguration runConfig, List<String> ret) { | |||
| // Custom networks can have circular links, no need to be considered for the starting order. | |||
| if (runConfig.getLinks() != null && !runConfig.getNetworkingConfig().isCustomNetwork()) { | |||
There was a problem hiding this comment.
Are you sure that getLinks() is never null ?
There was a problem hiding this comment.
I've added @Nonnull annotations to show the deduction chain. EnvUtil.splitAtCommasAndTrim(Iterable<String> input) never returns null.
| @@ -114,7 +114,7 @@ private void addContainerNetwork(RunImageConfiguration runConfig, List<String> r | |||
|
|
|||
| private void addDependsOn(RunImageConfiguration runConfig, List<String> ret) { | |||
| // Only used in custom networks. | |||
| if (runConfig.getDependsOn() != null && runConfig.getNetworkingConfig().isCustomNetwork()) { | |||
There was a problem hiding this comment.
why can't getDependsOn() be null ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow comma separated list of elements. (Similar to #558)
Info