Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding builder method to imageconfig #853

Merged

Conversation

nicolaferraro
Copy link
Member

.registry(...) was missing.

@codecov
Copy link

codecov bot commented Aug 28, 2017

Codecov Report

Merging #853 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #853      +/-   ##
============================================
+ Coverage     47.59%   47.62%   +0.02%     
- Complexity     1074     1075       +1     
============================================
  Files           134      134              
  Lines          6948     6950       +2     
  Branches        916      916              
============================================
+ Hits           3307     3310       +3     
+ Misses         3356     3355       -1     
  Partials        285      285
Impacted Files Coverage Δ Complexity Δ
...abric8/maven/docker/config/ImageConfiguration.java 47.88% <100%> (+2.95%) 12 <0> (+1) ⬆️

Copy link
Collaborator

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@rhuss
Copy link
Collaborator

rhuss commented Aug 28, 2017

[merge]

@fusesource-ci fusesource-ci merged commit bbc2fe9 into fabric8io:master Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants