Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended Authentication: allow usage of temporary security credentials #883

Merged
merged 2 commits into from
Oct 24, 2017
Merged

Extended Authentication: allow usage of temporary security credentials #883

merged 2 commits into from
Oct 24, 2017

Conversation

sebastiankirsch
Copy link
Contributor

In order to use temporary security credentials provided by the AWS
Security Token Service (AWS STS) to sign requests, the session token has
to be included.

In order to use temporary security credentials provided by the AWS
Security Token Service (AWS STS) to sign requests, the session token has
to be included. This can be done by using the `docker.authToken` system
property or by adding an <auth> element in the <authConfig>.

Signed-off-by: Sebastian Kirsch <sebastian.kirsch@gmail.com>
@codecov
Copy link

codecov bot commented Oct 24, 2017

Codecov Report

Merging #883 into master will increase coverage by 0.11%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #883      +/-   ##
============================================
+ Coverage     50.46%   50.57%   +0.11%     
- Complexity     1180     1185       +5     
============================================
  Files           137      137              
  Lines          7033     7037       +4     
  Branches        935      936       +1     
============================================
+ Hits           3549     3559      +10     
+ Misses         3177     3172       -5     
+ Partials        307      306       -1
Impacted Files Coverage Δ Complexity Δ
...io/fabric8/maven/docker/access/ecr/AwsSigner4.java 83.33% <100%> (+0.87%) 15 <0> (+1) ⬆️
...ava/io/fabric8/maven/docker/access/AuthConfig.java 94.59% <100%> (+0.15%) 11 <1> (+1) ⬆️
...ic8/maven/docker/access/ecr/AwsSigner4Request.java 75% <0%> (+2.5%) 20% <0%> (+1%) ⬆️
.../fabric8/maven/docker/access/util/RequestUtil.java 30.76% <0%> (+30.76%) 2% <0%> (+2%) ⬆️

Copy link
Collaborator

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ;-) Looks good to me and as I am no regular AWS user, I can't really verify.

So I trust you ;-)

@rhuss rhuss merged commit 4c5d015 into fabric8io:master Oct 24, 2017
@sebastiankirsch
Copy link
Contributor Author

Thanks, that was fast!
I forgot to ask if there's some integration/system tests that I've been missing. Although it would be a bit artificial to test against anything but AWS itself.

When will this be released?

@rhuss
Copy link
Collaborator

rhuss commented Nov 4, 2017

@sebastiankirsch 0.23.0 is out in the wild now. Thanks for providing this feature !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants