Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extended Authentication] Enable usage of system properties for HttpClient #897

Merged
merged 1 commit into from
Nov 10, 2017
Merged

[Extended Authentication] Enable usage of system properties for HttpClient #897

merged 1 commit into from
Nov 10, 2017

Conversation

sebastiankirsch
Copy link
Contributor

This allows using Extended Authentication behind a proxy, as it advices
the HttpClient to use the JVM's standard system properties for
proxies (https://docs.oracle.com/javase/6/docs/technotes/guides/net/proxies.html).

This allows using Extended Authentication behind a proxy, as it advices
the HttpClient to use the JVM's standard system properties for
proxies (https://docs.oracle.com/javase/6/docs/technotes/guides/net/proxies.html).
@sebastiankirsch sebastiankirsch changed the title Enable usage of system properties for HttpClient [Extended Authentication] Enable usage of system properties for HttpClient Nov 10, 2017
@codecov
Copy link

codecov bot commented Nov 10, 2017

Codecov Report

Merging #897 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #897   +/-   ##
=========================================
  Coverage     50.98%   50.98%           
  Complexity     1213     1213           
=========================================
  Files           140      140           
  Lines          7129     7129           
  Branches        956      956           
=========================================
  Hits           3635     3635           
  Misses         3178     3178           
  Partials        316      316
Impacted Files Coverage Δ Complexity Δ
...bric8/maven/docker/access/ecr/EcrExtendedAuth.java 92.68% <0%> (ø) 8 <0> (ø) ⬇️

@sebastiankirsch
Copy link
Contributor Author

sebastiankirsch commented Nov 10, 2017

To test this, I'd have to use wiremock or something similar, and I'm not sure if that's really worth the effort - but I can look into this if required...

@rhuss
Copy link
Collaborator

rhuss commented Nov 10, 2017

I don't think its worth the effort as it simply would test http client which we are using. I'm perfectly fine with this PR, thanks ;-)

@rhuss rhuss merged commit 949c71d into fabric8io:master Nov 10, 2017
@sebastiankirsch
Copy link
Contributor Author

Any chance for a new release?
Since we're sitting behind a corporate proxy, we can't use that feature otherwise.

@rhuss
Copy link
Collaborator

rhuss commented Jan 31, 2018

@sebastiankirsch I plan a release until the end of the week. sorry for the delay ...

@rhuss
Copy link
Collaborator

rhuss commented Feb 7, 2018

@sebastiankirsch 0.24.0 has been just released. sorry for the delay.

@sebastiankirsch
Copy link
Contributor Author

Thank you!
Now we can finally get rid of these bash scripts that build & push to AWS ECR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants