Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for tar creation missing dockerfile and wrong folder name #916

Closed
wants to merge 1 commit into from

Conversation

transamericamoon
Copy link
Contributor

@transamericamoon transamericamoon commented Dec 28, 2017

Currently plugin fails (does not copy dockerfile and uses folder named "tar" instead of "maven") during build when using inline assembly:

                <build>
                    <assembly>
                      <tarLongFileMode>posix</tarLongFileMode>
                      <mode>tar</mode>
                      <inline>
                        <fileSets>
                          <fileSet>
                            <directory>/Users/transamericamoon/project/dist</directory>
                            <outputDirectory>dist</outputDirectory>
                            <fileMode>644</fileMode>
                            <directoryMode>755</directoryMode>
                          </fileSet>
                        </fileSets>
                      </inline>
                    </assembly>
                    <dockerFile>/Users/transamericamoon/project/src/main/dockerCustomDockerFile</dockerFile>
                  </build>

@codecov
Copy link

codecov bot commented Dec 29, 2017

Codecov Report

Merging #916 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #916      +/-   ##
============================================
- Coverage      51.8%   51.78%   -0.03%     
  Complexity     1221     1221              
============================================
  Files           141      141              
  Lines          7161     7164       +3     
  Branches        960      962       +2     
============================================
  Hits           3710     3710              
- Misses         3135     3138       +3     
  Partials        316      316
Impacted Files Coverage Δ Complexity Δ
...8/maven/docker/assembly/DockerAssemblyManager.java 17.4% <0%> (-0.22%) 11 <0> (ø)

rhuss added a commit that referenced this pull request Jan 6, 2018
+ fixing the directory name of the included files.

Original fix is from #916
@rhuss
Copy link
Collaborator

rhuss commented Jan 6, 2018

Thanks a lot for this PR and the fix ! I adjusted it a bit and integrated into master aleady (19f7892), so I'm closing this PR for now. hope this ok for you ...

Thanks again ...

@rhuss rhuss closed this Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants