Use docker.skip.tag property on push and remove #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #954 +/- ##
============================================
- Coverage 51.67% 51.65% -0.02%
Complexity 1351 1351
============================================
Files 147 147
Lines 7439 7441 +2
Branches 1121 1123 +2
============================================
Hits 3844 3844
- Misses 3228 3230 +2
Partials 367 367
|
rhuss
reviewed
Mar 26, 2018
| * Skip building tags | ||
| */ | ||
| @Parameter(property = "docker.skip.tag", defaultValue = "false") | ||
| protected boolean skipTag; |
There was a problem hiding this comment.
Can we move this to the Mojos only where it makes sense (Build/Remove/Push) ? This leads to some duplication, true, but makes it clear that its not usable in other Mojos.
rhuss
requested changes
Mar 26, 2018
|
@rhuss - I made the requested updates to code, docs, and changelog. |
When pushing and removing images, the docker.skip.tag property is not used and can cause errors because the plugin will try to push and/or remove image tags that don't exist because they were skipped during the build process. Fixed bug in removing tagged images Code to remove tagged images was not creating the image name correctly Updated documentation and changelog Signed-off-by: Mark Whelan <mbwhelan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pushing and removing images, the docker.skip.tag property is not
used and can cause errors because the plugin will try to push and/or
remove image tags that don't exist because they were skipped during the
build process.
#869
Fix bug in removing tagged images
Code to remove tagged images was not creating the image name correctly
Signed-off-by: Mark Whelan mbwhelan@gmail.com