Skip to content

Commit c85237b

Browse files
committed
feat: user Vert.x as the default HttpClient implementation
Signed-off-by: Marc Nuri <marc@marcnuri.com>
1 parent a45d956 commit c85237b

File tree

7 files changed

+119
-59
lines changed

7 files changed

+119
-59
lines changed

.github/workflows/e2e-httpclient-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
fail-fast: false
4040
matrix:
4141
kubernetes: [v1.28.1,v1.27.5]
42-
httpclient: [jdk,jetty,vertx]
42+
httpclient: [jdk,jetty,okhttp]
4343
steps:
4444
- name: Checkout
4545
uses: actions/checkout@v4

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
* Fix #6158: Removed deprecated methods from `io.fabric8.kubernetes.client.utils.IOHelpers` class
4444
* Fix #6159: Removed deprecated `io.fabric8.kubernetes.client.utils.Utils.getPluralFromKind` method
4545
* Fix #6361: Renamed SettableBeanPropertyDelegate to SettableBeanPropertyDelegating
46+
* Fix #6470: Switched default HTTP client from OkHttp to Vert.x (`kubernetes-httpclient-vertx`)
4647
* Fix #6603: Removed deprecated `io.fabric8.openshift.api.model.runtime.RawExtension` class
4748
* Fix #6605: Removed deprecated `ApiVersionUtil` classes in extension modules
4849
* Fix #6609: Removed deprecated `io.fabric8.crd.generator.CRDInfo.getVersion` method

chaos-tests/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,13 @@
4949
<exclusions>
5050
<exclusion>
5151
<groupId>io.fabric8</groupId>
52-
<artifactId>kubernetes-httpclient-okhttp</artifactId>
52+
<artifactId>kubernetes-httpclient-vertx</artifactId>
5353
</exclusion>
5454
</exclusions>
5555
</dependency>
5656
<dependency>
5757
<groupId>io.fabric8</groupId>
58-
<artifactId>kubernetes-httpclient-okhttp</artifactId>
58+
<artifactId>kubernetes-httpclient-vertx</artifactId>
5959
<scope>test</scope>
6060
</dependency>
6161

doc/FAQ.md

Lines changed: 99 additions & 49 deletions
Large diffs are not rendered by default.

doc/MIGRATION-v7.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
## Contents
44
- [Java baseline set to Java 11](#java-11)
5+
- [Vert.x as default HttpClient implementation](#vertx-httpclient)
56
- [Bouncy Castle is no longer needed](#bouncy-castle)
67
- [Config changes](#config-changes)
78
- [Support for multiple kubeconfig files](#config-changes-multiple-kubeconfig)
@@ -41,6 +42,14 @@ Starting from version 7.0.0, you will need a Java 11+ runtime (using the latest
4142
It's been more than 10 years since Java 8 was released, and it's no longer supported by most vendors.
4243
We made our best effort to keep the client compatible with Java 8 for as long as possible, but it's time to move on.
4344

45+
## Vert.x as default HttpClient implementation <a href="#vertx-httpclient" id="vertx-httpclient"/>
46+
47+
OkHttp has been replaced by Vert.x as the default HttpClient implementation.
48+
As of version 7.0.0, the Fabric8 Kubernetes Client `io.fabric8:kubernetes-client` and `io.fabric8:openshift-client` include a transitive dependency to the `io.fabric8:kubernetes-httpclient-vertx` module.
49+
50+
If you want to continue using OkHttp as the HttpClient, you can do so by adding the `io.fabric8:kubernetes-httpclient-okhttp` module as a dependency.
51+
It is also recommended (although not mandatory) to add an exclusion for the `io.fabric8:kubernetes-httpclient-vertx` module to avoid having both implementations in the classpath.
52+
4453
## Bouncy Castle is no longer needed <a href="#bouncy-castle" id="bouncy-castle"/>
4554

4655
The Bouncy Castle library is no longer needed as a dependency.

kubernetes-client/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
</dependency>
6868
<dependency>
6969
<groupId>io.fabric8</groupId>
70-
<artifactId>kubernetes-httpclient-okhttp</artifactId>
70+
<artifactId>kubernetes-httpclient-vertx</artifactId>
7171
<scope>runtime</scope>
7272
</dependency>
7373

@@ -205,7 +205,7 @@
205205
</goals>
206206
<configuration>
207207
<excludeDependencies>
208-
kubernetes-httpclient-okhttp
208+
kubernetes-httpclient-vertx
209209
</excludeDependencies>
210210
<instructions>
211211
<Bundle-Name>${project.name}</Bundle-Name>

kubernetes-itests/pom.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@
102102
<exclusions>
103103
<exclusion>
104104
<groupId>io.fabric8</groupId>
105-
<artifactId>kubernetes-httpclient-okhttp</artifactId>
105+
<artifactId>kubernetes-httpclient-vertx</artifactId>
106106
</exclusion>
107107
</exclusions>
108108
</dependency>
@@ -122,7 +122,7 @@
122122
<exclusions>
123123
<exclusion>
124124
<groupId>io.fabric8</groupId>
125-
<artifactId>kubernetes-httpclient-okhttp</artifactId>
125+
<artifactId>kubernetes-httpclient-vertx</artifactId>
126126
</exclusion>
127127
</exclusions>
128128
</dependency>
@@ -133,7 +133,7 @@
133133
</dependencies>
134134
</profile>
135135
<profile>
136-
<id>httpclient-vertx</id>
136+
<id>httpclient-okhttp</id>
137137
<dependencies>
138138
<dependency>
139139
<groupId>io.fabric8</groupId>
@@ -142,13 +142,13 @@
142142
<exclusions>
143143
<exclusion>
144144
<groupId>io.fabric8</groupId>
145-
<artifactId>kubernetes-httpclient-okhttp</artifactId>
145+
<artifactId>kubernetes-httpclient-vertx</artifactId>
146146
</exclusion>
147147
</exclusions>
148148
</dependency>
149149
<dependency>
150150
<groupId>io.fabric8</groupId>
151-
<artifactId>kubernetes-httpclient-vertx</artifactId>
151+
<artifactId>kubernetes-httpclient-okhttp</artifactId>
152152
</dependency>
153153
</dependencies>
154154
</profile>

0 commit comments

Comments
 (0)