Connection leak in OpenShiftOAuthInterceptor

[snjeza]

See https://github.com/fabric8io/kubernetes-client/blob/master/openshift-client/src/main/java/io/fabric8/openshift/client/internal/OpenShiftOAuthInterceptor.java#L85

"response.body().close();" releases a connection properly when using the standard http services
When using a web socket, "response.body().close();" doesn't release a connection.

The following OpenShiftOAuthInterceptor.intercept method fixes the issue:

@Override
    public Response intercept(Chain chain) throws IOException {
        Request request = chain.request();
        //Build new request
        Request.Builder builder = request.newBuilder();
        String token = oauthToken.get();
        if (Utils.isNotNullOrEmpty(token)) {
            setAuthHeader(builder, token);
        } else {
            if (Utils.isNotNullOrEmpty(config.getUsername()) && Utils.isNotNullOrEmpty(config.getPassword())) {
                synchronized (client) {
                  token = authorize();
                  if (token != null) {
                    oauthToken.set(token);
                  }
                }
              } else if (Utils.isNotNullOrEmpty(config.getOauthToken())) {
                token = config.getOauthToken();
                oauthToken.set(token);
              }
            if (Utils.isNotNullOrEmpty(token)) {
                setAuthHeader(builder, token);
            }
        }
        request = builder.build();
        return chain.proceed(request);
    }

The method adds an authorization token to all requests no matter if they require authentication or not.
Not sure if that is acceptable.

See https://issues.jboss.org/browse/CHE-180 for more detail.

[stale]

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!