Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5.0 Issue - Circle fill not saving correctly when converted to JSON #2119

Closed
noctivityinc opened this issue Apr 16, 2015 · 2 comments · Fixed by #2101
Closed

v1.5.0 Issue - Circle fill not saving correctly when converted to JSON #2119

noctivityinc opened this issue Apr 16, 2015 · 2 comments · Fixed by #2101
Assignees
Labels
Milestone

Comments

@noctivityinc
Copy link

Just upgraded to 1.5 and found an immediately problem.

Im generating a group with the following circle and text:

screen shot 2015-04-16 at 2 19 36 pm

The circle is generated easily with:

circle = new fabric.Circle
radius: 12,
fill: 'rgb(255,255,255)'
stroke: '#dddddd'
strokeWidth: 1
originX: 'center'
originY: 'center'

But when I JSON.stringify(canvas) the canvas the fill for the circle is stored as

rgb(0,0,0)

Thanks,

Josh

@sapics
Copy link
Contributor

sapics commented Apr 17, 2015

Thank your for teaching!
I made the PR #2101 for fix this problem, and your post makes me think more about consistency with previous version.

@asturur
Copy link
Member

asturur commented Apr 22, 2015

regarding this issue, @noctivityinc you say the value is not stored correctly.
The PR #2101 is about loading back json, not storing it.

Could you be more precise if this is about storing or loading back?
Can you paste here your JSON string?

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants