Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textbox - "selection:changed" event fires twice. #3116

Closed
belfz opened this issue Jul 18, 2016 · 3 comments · Fixed by #3119
Closed

Textbox - "selection:changed" event fires twice. #3116

belfz opened this issue Jul 18, 2016 · 3 comments · Fixed by #3119
Labels
Milestone

Comments

@belfz
Copy link
Contributor

belfz commented Jul 18, 2016

Version

1.6.2

Test Case

http://jsfiddle.net/rrrgye4u/

Steps to reproduce

  1. Add canvas and Textbox.
  2. Put a cursor in the text. Move the cursor with left/right arrows on the keyboard.
  3. Observe the counter above the canvas - the 'selection:changed' event fires twice each time.

Expected Behavior

'selection:changed' should fire only once per each cursor position change.

Actual Behavior

'selection:changed' event fires twice per each cursor position change.

@belfz belfz changed the title Textbox - "selection:changed" event fired twice. Textbox - "selection:changed" event fires twice. Jul 18, 2016
@asturur asturur added the bug label Jul 18, 2016
@asturur asturur added this to the 1.6.4 milestone Jul 18, 2016
@asturur
Copy link
Member

asturur commented Jul 20, 2016

yes i think somewhere we call setSelectionStart and setSelectionEnd togheter.

@asturur
Copy link
Member

asturur commented Jul 31, 2016

i checked all selection:changed events and made some changes. Would you give a check again?

@belfz
Copy link
Contributor Author

belfz commented Aug 2, 2016

It seems to be working fine now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants