Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IText/Textbox - creating selection with click & shift+click doesn't work #3133

Closed
belfz opened this issue Jul 29, 2016 · 6 comments
Closed

Comments

@belfz
Copy link
Contributor

belfz commented Jul 29, 2016

Version

1.6.3

Test Case

http://jsfiddle.net/bn8vaw2e/

Steps to reproduce

Position the cursor just after last letter of the text. Shift click on the beginning of the text (to the left of the first letter). No selection is created.
Used to work fine in v.1.6.2 (downgrading however is not an option - in v.1.6.2 selecting a text with click&drag to left/right didn't work).

Expected Behavior

As per IText documentation, create selection should work on click & shift + click.

Actual Behavior

Positioning a cursor via click and then performing shift+click doesn't create a selection.

@asturur
Copy link
Member

asturur commented Aug 1, 2016

Can you check again on your fiddle with the updated build? it looks working to me.

@belfz
Copy link
Contributor Author

belfz commented Aug 1, 2016

That's surprising. It seems to be working fine now. Did you actually fix that without releasing new version?

EDIT: Have you released the fixed code to npm? Because the freshly-installed npm version (1.6.3) still has these bugs.

@asturur
Copy link
Member

asturur commented Aug 1, 2016

npm is still 1.6.3 as it was.
Master branch contains 1.6.3 And fixes for:
Improvement: Ignore svg: namespace during svg import. #3081
Improvement: Better fix for lineHeight of iText/Text #3094
Improvement: Support for gradient with 'Infinity' coordinates #3082
Improvement: Generally "improved" logic of targeting #3111
Fix: Selection of active group with transparency and preserveObjectStacking true or false #3109
Fix: pattern brush now create the same pattern seen while drawing #3112
Improvement: added numeric origins handling fomr 0 to 1. #3121
Fix: Fix a defect with shadow of objects in a scaled group. #3134
Improvement: Do not fire unecessary selection:changed events. #3119

@asturur
Copy link
Member

asturur commented Aug 1, 2016

as soon as i manage to clear all the things i tagged with 1.6.4 i will release 1.6.4 to cdn and npm.

@asturur
Copy link
Member

asturur commented Aug 1, 2016

Let me know if i can close this issue.

@belfz
Copy link
Contributor Author

belfz commented Aug 1, 2016

@asturur thank you very much for clarification. Yes, this can be closed. Cheers!

@asturur asturur closed this as completed Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants