Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying filters to updated Image objects (with new image) shows old image #4405

Closed
thomastuts opened this issue Oct 24, 2017 · 2 comments · Fixed by #4410
Closed

Applying filters to updated Image objects (with new image) shows old image #4405

thomastuts opened this issue Oct 24, 2017 · 2 comments · Fixed by #4410
Labels

Comments

@thomastuts
Copy link

Version

2.0.0-beta7

Test Case

http://jsfiddle.net/Da7SP/710/

Steps to reproduce

Click the 'Randomize image' button (you might have to click it several times since it's using a random src URL)

Expected Behavior

The image should change to a new image, and have the Sepia filter applied to it

Actual Behavior

The dimensions get updated, but the old image is still displayed. I want the new image to show up with a Sepia filter applied to it as well. As noted in the test case code, commenting line 56 results in the new image showing up just fine, but without the Sepia filter applied. I tried clearing the filters using .applyFilters([]), but that didn't work either.

@asturur asturur added the bug label Oct 24, 2017
@asturur
Copy link
Member

asturur commented Oct 24, 2017

looks a but, like if setElement is not clearing the old filteredElement.

Needs a fix.

@asturur
Copy link
Member

asturur commented Oct 25, 2017

it is a webgl problem, the texture cached at first filtering wasn't being cleared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants