Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug regression: excludeFromExport in overlayImage and bgImage is not working again #4587

Closed
salomonsanz opened this issue Dec 28, 2017 · 5 comments
Labels

Comments

@salomonsanz
Copy link

Version

1.20

Description

The bug/feature "excludeFromExport" in overlayImage and backgroundImage in version 1.7.17

Fix: avoid exporting bgImage and overlayImage if excludeFromExport = true #4119

But is failing again, ignoring this property and the overlayImage is exported to svg
https://jsfiddle.net/vkLt8938/1/

@asturur
Copy link
Member

asturur commented Dec 29, 2017

The exclude from export is supposed to work for toObject for serialize / deserialize purpose.
It does not involve toSVG process nor toDataURL.

@asturur
Copy link
Member

asturur commented Dec 29, 2017

I close the issue since there is nothing to fix, the topic is open if you want to talk about something else.

@asturur asturur closed this as completed Dec 29, 2017
@salomonsanz
Copy link
Author

in the docs says that includes also SVG serialization:

http://fabricjs.com/docs/fabric.Object.html#excludeFromExport

When true, object is not exported in SVG or OBJECT/JSON since 1.6.3

So, or is wrong the docs, or is a bug.

It makes sense that it works this way, affecting both.

@asturur
Copy link
Member

asturur commented Jan 6, 2018

well hard call then.
I think that png and svg export should be same.

@asturur asturur reopened this Jan 6, 2018
@asturur asturur added the docs label Apr 1, 2018
@asturur
Copy link
Member

asturur commented Apr 1, 2018

updated docs

@asturur asturur closed this as completed Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants