-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WPF, WinForms, Mac nodes to samples #55
Comments
I was able to get a WPF sample working, but to do this, we have to upgrade Xamarin.Forms in all projects to last stable release 3.0.482510, what do you think about this? |
Seems sensible to me. We upgraded all the templates (apart from F#, I didn't have the time 😞 ) to XF 3.0 |
And with WinForms I haven't notice before, but the Aosoft's library has no Nuget package, we would have to do it another way. 😢 |
Do you need to update the Xamarin.Forms.Core in the "neutral" group? That's the one we build Elmish.XamarinForms.dll against. I would prefer that keeps the lowest dependency possible, e.g. to allow us to use it with as many 3rd party components as possible. The Android, iOS and WPF projects (e.g. anroidapp group in pakt.dependencies) can all run with XF latest. My understanding is that XF is binary compat, so this approach should work? |
Could you send a PR for this so I can take a look? Thanks! |
There it is: #56 But, if there is 2 versions of Xamarin.Forms in the same solution there is even a message warning about this in the build. |
I added WPF to the AllControls sample without any material changes to other parts of the sample (including upgrading Xamarin.Forms in other projects). Some of the other projects don't build on my machine but considering I didn't change any of them I assume they continue to work. |
Could we target UWP also? I know I'd have use for it. |
Oh, I traced the trail of breadcrumbs to dotnet/corert#5780, and can see that question might be premature. |
Please add that @bugQ . Getting this running is easy, except release to store which is in testing. You can add a UWP project, min Windows version FCU. Put You can also copy over from a C# Xamarin.Forms template if you prefer. You can then run in debug mode, and test in release mode using the instructions in the thread you linked. You'll need to do this for each of the samples. |
Thanks for the encouragement and instructions, @charlesroddie. After referencing sample Xamarin.UWP projects and figuring out that there was one missing step (changing the class of the So, basically, everything is set for UWP, too, at least for local testing. I'll submit a PR shortly. |
Thanks @charlesroddie, @bugQ. It works |
oh, I actually completely spaced this one. thank @TimLariviere 😅 |
But what about integration with UWP Frame? Can it be used with Fabulous to switch pages? |
@xperiandri Do you mean navigating from page to page inside the app, or embedding a page in another one? If you specifically need to use UWP's |
From slack discussion with @charlesroddie and @mydogisbox
Let's add a sample under https://github.com/fsprojects/Elmish.XamarinForms/tree/master/Samples/CounterApp
I'd like to also see WinForms and Mac nodes under there.
Here's a sample from @mydogisbox:
The text was updated successfully, but these errors were encountered: