Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic HTML #83

Open
tonylomax opened this issue Mar 30, 2023 · 0 comments
Open

Semantic HTML #83

tonylomax opened this issue Mar 30, 2023 · 0 comments

Comments

@tonylomax
Copy link
Collaborator

Not sure about using div tags here. I think a button tag might be more semantically appropriate and accessible.

<Rectangle backgroundColor="var(--main-green)">
<div className={styles['category-task']}>
<p>{task.name}</p>
<div
className={styles.checkboxContainer}
id={task.id}
onClick={onChecked}>
{complete && (
<div className={styles.checkboxMark}>
<Image
src="/icons/check-mark.svg"
alt="check mark"
width={20}
height={20}
/>
</div>
)}
</div>
</div>
</Rectangle>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant