New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General code review #56

Open

4 tasks

ko-karol opened this issue Jun 1, 2023 · 0 comments

Labels

ko-karol commented Jun 1, 2023 •

edited

Loading

File structure is good, code is mostly clean. Good work overall! 👍

Here's a few things I noticed:

Clean up branches
There are so many branches :(
When you approve a pull request, it's a good idea to delete the branches straight away before you start working on new ones.
Change dev branch to main?
I think dev branch became the new main branch? lol
Sanitise your inputs
The function exists, but just needs to be put into effect.
Add some styling
🤷

ko-karol changed the title ~~CR: Repo~~ General code review

ko-karol added the code-review label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment