fix: truncate blogpost properly with truncate-html #880
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #719
Instead of naively cutting down markdown at certain length and then render it to HTML, we render markdown to HTML first and then truncate it (keeping html tag safe) using https://www.npmjs.com/package/truncate-html
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Consider this blogpost file
Before
Notice how the URL got cut naively, resulting on broken link like below
[ReasonML](<a href="https://github.com/reaso">https://github.com/reaso</a>
After
Notice how the URL is preserved
<a href="https://github.com/reasonml">ReasonML</a> <a href="https://github.com/reasonml/reason-react">Reason React</a>