Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete unused/ old file #881

Merged
merged 1 commit into from
Aug 1, 2018
Merged

chore: delete unused/ old file #881

merged 1 commit into from
Aug 1, 2018

Conversation

endiliey
Copy link
Contributor

@endiliey endiliey commented Aug 1, 2018 •
edited
Loading

Motivation

Remove https://github.com/facebook/Docusaurus/blob/master/lib/generate-feed.js

  1. It's not being used
  2. The functionality is just to console.log
  3. It's not even in docusaurus user scripts (E.g: https://github.com/facebook/jest/blob/master/website/package.json)
  4. Executing it results in an error. Try node ../lib/generate-feed.js from website folder

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

No changes in Docusaurus functionality

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 1, 2018
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 26927e1

https://deploy-preview-881--docusaurus-preview.netlify.com

@endiliey endiliey merged commit 42a9669 into facebook:master Aug 1, 2018
@endiliey endiliey deleted the delete branch August 1, 2018 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@endiliey @docusaurus-bot @facebook-github-bot