Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curbs feature spits out error #1654

Closed
wolfy1339 opened this issue Dec 23, 2024 · 3 comments · Fixed by #1671
Closed

Add curbs feature spits out error #1654

wolfy1339 opened this issue Dec 23, 2024 · 3 comments · Fixed by #1671
Assignees
Labels
bug Something isn't working
Milestone

Comments

@wolfy1339
Copy link

wolfy1339 commented Dec 23, 2024

Description

I tried using the "add curbs" feature in Rapid and now it refuses to pan the map or use any of the suggested fixes

Uncaught TypeError: this.tags is null
    isArea https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089
    geometry https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089
    transient https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089
    geometry https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089
    summary https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089
    render https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:7389
    rerender https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:7389
    emit https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1
    _updateChanges https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:3299
    commit https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:3299
    onClick https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:7395
    E https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:7286
    sq https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089
rapid.min.js:1089:75495
    isArea https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089
    geometry https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089
    transient https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089
    geometry https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089
    summary https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089
    render https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:7389
    rerender https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:7389
    emit https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1
    _updateChanges https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:3299
    commit https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:3299
    onClick https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:7395
    E https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:7286
    sq https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089

Screenshots

No response

Version

2.5.0

What browser are you seeing the problem on? What version are you running?

Firefox v133

The OS you're using

Fedora 41

Steps to reproduce

  1. Go to an area that has seperate crossing way tagged
  2. Try to use the "add curbs" feature
  3. Nothing happens
  4. Try to pan to a different area
  5. Select a seperate crossing way that has suggested fixes, try to apply a fix

The browser URL at the time you encountered the bug

https://rapideditor.org/edit#map=20.70/46.78296/-71.28594&background=custom:https://servicesmatriciels.mern.gouv.qc.ca/erdas-iws/ogc/wmts/Imagerie_Continue/Imagerie_GQ/default/GoogleMapsCompatibleExt2:epsg:3857/{z}/{y}/{x}.jpg&datasets=fbRoads,msBuildings&id=w1295769714

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

Mozilla/5.0 (X11; Linux x86_64; rv:133.0) Gecko/20100101 Firefox/133.0

@wolfy1339
Copy link
Author

It seems this doesn't always reproduce. It seems to happen when it can't deduce where to place the curbs?
The rendering is also affected by this

@wolfy1339
Copy link
Author

Sometimes reloading the page and restoring the data works, sometimes it spits out errors

Uncaught Error: Entity w-7 not found
    entity https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089
    parentWays https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089
    parentWays https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089
    _includeParents https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089
    _setCurrentGraph https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089
    intersects https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:1089
    intersects https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:3299
    render https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:7271
    render https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:7271
    _app https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:7271
    _tick https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:7271
    emit https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:6
    update https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:6
    _tick https://rapideditor.org/rapid/release-097e7f6/rapid.min.js:6
rapid.min.js:1089:140120

@bhousel bhousel added the bug Something isn't working label Dec 24, 2024
@mxxcon
Copy link

mxxcon commented Dec 31, 2024

I'm on Win11 23H2, Microsoft Edge 131.0.2903.112

I had a single "box" of crosswalks with no sidewalks attached. I split that box into 4 sidewalk ways. Then I clicked on "add lowered curb nodes" my map broke. I can't pan it. I can't select anything, but on mouse-over I see things in the left panel, but nothing gets highlighted on the map.
When I clicked on submit changes because I had some other edits nearby, I got broken changeset comment panel that you see in this screenshot.
image

If I refresh browser tab and restore changes, it becomes broken again.
If I refresh the tab but don't restore changes, everything works.

I was able to replicate this bug by drawing 2 crosswalk ways connected to each other but no connecting sidewalks. Then when I tried to add curbs things broke.
Dev tools shows this error.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants