Edit of ways tends to freeze 1.0.11

[jjiglesiasg]

The selection of a line (edited of to be created), or node, tends to freeze quite often and only could be released chosing "save" and them "escape" to keep editing.

Also in the Comments box, currently do not display previous comments when hit the lower arrow.

In general Version 1.0.11 is quite slow in comparison with ID 2.18.4

BsRgds

JJ

[Bonkles]

Hi there!

Would you mind posting:

• a screenshot & URL of where you were performing edits when you encountered these issues
• Whether the performance differences you see vs. iD 2.18.4 go away if you turn the RapiD layer off (Shift+R)?
• What browser you're using
• Any bugs or errors that you see in the console when you experience the 'selection of a line freezes' issue.

[bos]

I've run into this lockup issue too, after a minute or two of editing. It's independent of location. Doesn't matter whether RapiD is enabled or not.

It does seem to be correlated with a stack trace:

Uncaught TypeError: l.graph is not a function
    at operationDelete (iD.min.js:1)
    at e (iD.min.js:1)
    at iD.min.js:1
    at Array.forEach (<anonymous>)
    at f (iD.min.js:1)
    at iD.min.js:1
    at Set.forEach (<anonymous>)
    at g (iD.min.js:1)
    at Object.n.validate (iD.min.js:1)
    at Dispatch.call (iD.min.js:1)

[bhousel]

Thanks for reporting @bos & @jjiglesiasg ..
Looks like there is a bug in our short_road and y_shaped_connection validators.

Apparently openstreetmap/iD@db9eed2 swapped the argument order for all the operations from:
fn([ids], context) to fn(context, [ids])

So we need to swap the argument order in our RapiD validation code as well:
https://github.com/facebookincubator/RapiD/blob/e4e1908efdd976386f79a5cde1f4db957b255a4a/modules/validations/y_shaped_connection.js#L54
https://github.com/facebookincubator/RapiD/blob/e4e1908efdd976386f79a5cde1f4db957b255a4a/modules/validations/short_road.js#L84

It only surfaces occasionally because it depends on whatever the validator finds.

[Bonkles]

I've run into this lockup issue too, after a minute or two of editing. It's independent of location. Doesn't matter whether RapiD is enabled or not.

It does seem to be correlated with a stack trace:

Uncaught TypeError: l.graph is not a function
    at operationDelete (iD.min.js:1)
    at e (iD.min.js:1)
    at iD.min.js:1
    at Array.forEach (<anonymous>)
    at f (iD.min.js:1)
    at iD.min.js:1
    at Set.forEach (<anonymous>)
    at g (iD.min.js:1)
    at Object.n.validate (iD.min.js:1)
    at Dispatch.call (iD.min.js:1)

Thank you so incredibly much for the stack trace- these are incredibly helpful for rooting out the bugs. I'll turn the release crank and get these fixes in today.

[Bonkles]

Release 1.0.12 just went out with these fixes. Please give Rapid another try!