Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax eslint-related packages versions #1161

Closed
EnoahNetzach opened this issue Dec 5, 2016 · 6 comments
Closed

Relax eslint-related packages versions #1161

EnoahNetzach opened this issue Dec 5, 2016 · 6 comments

Comments

@EnoahNetzach
Copy link
Contributor

We are using a secondary custom eslint during CI (extending airbnb rules).
Prior to v0.8.0 the version ranges were miraculously matching, now they are no more.

Is it possible for react-scripts to relax its eslint-related peerDependencies, passing from exact to either ^ or to a specific range?

I'd gladly check the possible range and propose a PR.

@gaearon
Copy link
Contributor

gaearon commented Dec 5, 2016

I think this is a duplicate of #1110.
I’m happy to take a PR relaxing them to ~ versions (^ seems too lax).
Would that work for you?

@gaearon
Copy link
Contributor

gaearon commented Dec 5, 2016

Actually I think I’m fine with ^ in the preset since we still enforce specific versions in react-scripts itself.

@gaearon
Copy link
Contributor

gaearon commented Dec 5, 2016

Closing in favor of #1110.

@gaearon gaearon closed this as completed Dec 5, 2016
@EnoahNetzach
Copy link
Contributor Author

@gaearon #1110 is about eslint-config-react-app, here I mean the specific versions in react-scripts.

@gaearon
Copy link
Contributor

gaearon commented Dec 5, 2016

But react-scripts doesn't have peer deps. Peer deps are only in ESLint preset. Deps in react-scripts are the ones satisfying those.

@EnoahNetzach
Copy link
Contributor Author

mumble mumble mumble... I think I need a vacation 😛

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants