-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React errors UI appears differently #11804
Comments
It's a lot better error message and can be closed, so I don't see why it should be changed back? |
@RichardLindhout That's a very subjective analysis and the initial example is skewed. Objectively, here are the two side by side (using the stock CRA example, both images at native resolution): First off, "can be closed" is completely irrelevant since it's a build error, and second, the only objective difference is the additional stack trace on the new overlay, which arguably isn't important for a build error anyways. It comes down to which UI looks more visually pleasing to the developer, which isn't worth arguing over. What is worth arguing over is that the new error overlay does not report runtime errors. This is a huge difference and unless the new UI implements this, the old UI is objectively superior. For runtime errors, the new overlay is a blank screen, unreported, forcing the developer to rely on console output, whereas the old overlay has the error message, a stack trace (clickable, taking you to the the file and line in your IDE), and (since it is a runtime error) the overlay is closable: New overlay in runtime error scenario (console output provided since there is no overlay in this case): Old overlay in runtime error scenario: I agree with @xnukernel (although for a different reason) that the new overlay is not yet a sufficient replacement for the old one. |
Ok valid reasons @obsius! I just liked the close button and in my case some errors were more understandable :) |
@RichardLindhout No hard feelings. I just don't want this ticket to be so readily dismissed and closed out before all changes of the new overlay are justified. In my opinion, the new overlay is visually ok (although I slightly prefer the smaller text of the old), but feature-wise it should be at parity with the old one. Maybe I'm missing something, but I pulled stock CRAv5 and don't see runtime errors onscreen, which to me is a big regression. Although a minor inconvenience, developers now need to eject and add/change a few lines to the webpack and dev server config files to regain the runtime error. |
see this comment aaddb29#r696840791
|
Agreed 200%. I'm running across this while learning React this seems like an unfortunate change to me. Am I missing something? The full screen errors messages I'm seeing in some of the tutorials are so much better than the blank screen I'm seeing in my fresh Being new to React this seems like a huge step backwards (just getting a blank screen). |
Good morning, @xnukernel, Any updates on this issue? If there is no activity, it can be closed and reopened in the future. Thanks. |
I see we recently updated to v5.0.0 and there were some changes to the
react-error-overlay
. Can we revert back to the old version?This new one has less information, features, and is much harder to read. What happened here?
New – worse UI:
Old – better UI:
The text was updated successfully, but these errors were encountered: