Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularise scripts #1431

Closed
djgrant opened this issue Jan 23, 2017 · 2 comments
Closed

Modularise scripts #1431

djgrant opened this issue Jan 23, 2017 · 2 comments
Milestone
1.0.0

Comments

@djgrant
Copy link
Contributor

djgrant commented Jan 23, 2017

Would a PR to modularise scripts in react-scripts be considered?

For example, with start.js:

scripts
    start.js
utils
    addWebpackMiddleware.js
    createWebpackCompiler.js
    createWebpackDevServer.js
    runWebpackDevServer.js

Reasons for doing this:

  1. Clearer for new contributors and people reading code for learning
  2. Make the process of modifying an ejected CRA app simpler
  3. Make scripts more extensible in ejected apps and forks (by removing interweaving and enabling reuse)
  4. Reduce complexity of upstream merges to forks of create-react-app (my motivation)
@gaearon
Copy link
Contributor

gaearon commented Jan 23, 2017

Sounds good, let's give it a try!

@djgrant djgrant mentioned this issue Jan 23, 2017
Merged
@Timer Timer added this to the 0.10.0 milestone Mar 4, 2017
@gaearon
Copy link
Contributor

gaearon commented Mar 4, 2017

Fixed by #1433.

@gaearon gaearon closed this as completed Mar 4, 2017
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@Timer @gaearon @djgrant