e2e fails when the path has space

[viankakrisna]

If you are reporting a bug, please fill in below. Otherwise feel free to remove this template entirely.

Can you reproduce the problem with latest npm?

Yes

Description

e2e fails when pwd has space in its path. eg /Users/adeviankakrisnafadlil/Local Sites/create-react-app

What are you reporting?

bug

Expected behavior

It should run the e2e test

Actual behavior

It fails with this error:

+ cd /Users/adeviankakrisnafadlil/Local Sites/create-react-app/packages/create-react-app
tasks/e2e-simple.sh: line 115: cd: /Users/adeviankakrisnafadlil/Local: No such file or directory
++ set +x
e2e-simple.sh: ERROR! An error was encountered executing line 115.
Cleaning up.
tasks/e2e-simple.sh: line 24: cd: /Users/adeviankakrisnafadlil/Local: No such file or directory
Exiting with error.

Environment

Run these commands in the project folder and fill in their results:

1. npm ls react-scripts (if you haven’t ejected): 9.2.0
2. node -v: v7.4.0
3. npm -v: 4.0.5

Then, specify:

1. Operating system: macOs Sierra
2. Browser and version: n/a

Reproducible Demo

Just rename your current create-react-app repo with create react-app or rename the parent folder to have space in it

[Timer]

Would you like to submit a pull request fixing this? 😄

[viankakrisna]

Haven't found the fix yet T_T
Will dig more tomorrow, in the meantime maybe someone with power in shell scripting could help? 😄

[Timer]

I believe we just need to wrap usages of cd (and related commands) with ".

e.g. cd $root_path/packages/react-scripts -> cd "$root_path/packages/react-scripts"

[viankakrisna]

ok then, i thought just wrapping PWD with it would be sufficient, will do it tomorrow, it's quite a lot and haven't got a good sleep today 😄

[Timer]

@viankakrisna will you take a look at this soon? 😄