Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t break words apart in the error box #1853

Closed
gaearon opened this issue Mar 18, 2017 · 2 comments · Fixed by #1842
Closed

Don’t break words apart in the error box #1853

gaearon opened this issue Mar 18, 2017 · 2 comments · Fixed by #1842

Comments

@gaearon
Copy link
Contributor

gaearon commented Mar 18, 2017

Just noticed the error box is breaking words apart (e.g. "s/newline/tring").
This should not happen.

screen shot 2017-03-18 at 15 32 41

I also don’t think the error text should be monospace. Makes it a bit hard to read.

@gaearon gaearon added this to the 0.10.0 milestone Mar 18, 2017
@Timer
Copy link
Contributor

Timer commented Mar 18, 2017

Another thing I noticed is that the app's CSS influences the overlay, so we should look into preventing that (e.g. bootstrap).
Would an iframe accomplish this?

@gaearon
Copy link
Contributor Author

gaearon commented Mar 18, 2017

Yea, iframe would do the trick (the reason I used iframe for syntax error overlay).

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants