Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding more libraries to existing codebase without ejecting? #1961

Closed
anilreddykatta opened this issue Apr 10, 2017 · 2 comments
Closed

adding more libraries to existing codebase without ejecting? #1961

anilreddykatta opened this issue Apr 10, 2017 · 2 comments

Comments

@anilreddykatta
Copy link
Contributor

anilreddykatta commented Apr 10, 2017

I really love this project, great way to kick start very quickly.

To add SASS or any other libraries, currently, I am ejecting and customizing my configs. How do you feel about abstracting this? I am not sure whether this is good or bad idea. Curious to know community opinion.

When anyone wants to add sass to create react app, doing something like create-react-app --add sass should create a config with sass support. Anybody writing libraries should be able to add basic config how they interface with create-react-app which should be the starting point for interfacing with this awesome project.

{
 loader: {
  test: '*.scss',
  loader: ['sass-loader']
 }
}

Something like this?

@Timer
Copy link
Contributor

Timer commented Apr 10, 2017

We provide docs for integrating with Sass and do not plan to add an ability to extend webpack configuration.

You can checkout (though not officially endorsed) https://github.com/timarney/react-app-rewired which lets you make these sorts of modifications.

This has been extensively discussed on many previous issues, sorry (feel free to search for them)!

@Timer Timer closed this as completed Apr 10, 2017
@Timer
Copy link
Contributor

Timer commented Apr 10, 2017

If you'd like, you can help discuss plugins in #670.

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants