Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off eslint rule: operator-assignment #2245

Closed
ro-savage opened this issue May 19, 2017 · 1 comment
Closed

Turn off eslint rule: operator-assignment #2245

ro-savage opened this issue May 19, 2017 · 1 comment
Milestone

Comments

@ro-savage
Copy link
Contributor

The linting in the console / terminal is suppose to be sensible defaults + things that cause common bugs.

The operator-assignment rule is generally just visual (and plenty of people argue for and against).

total = total + subtotal
vs
total += subtotal

or

total = total + (parseInt(ticket.ticketPrice, 10) * parseInt(ticket.ticketCount, 10))
vs
total += parseInt(ticket.ticketPrice, 10) * parseInt(ticket.ticketCount, 10)

The linting rule should be removed so people can choose their own preference.

Happy to submit PR if approved.

@gaearon
Copy link
Contributor

gaearon commented May 19, 2017

Yea let's disable it.

@gaearon gaearon added this to the 1.0.1 milestone May 19, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants