Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint 4 #2644

Closed
gaearon opened this issue Jun 27, 2017 · 5 comments
Closed

ESLint 4 #2644

gaearon opened this issue Jun 27, 2017 · 5 comments
Labels
tag: internal

Comments

@gaearon
Copy link
Contributor

gaearon commented Jun 27, 2017

As we update, need to make sure we don't regress on #2604 and #2631.

While we're at it, we should also look at using webpack-contrib/eslint-loader#183 to avoid hoisting issues going forward.
@gaearon gaearon mentioned this issue Jun 27, 2017
Closed
@leiming leiming mentioned this issue Jun 28, 2017
Closed
@timdorr timdorr mentioned this issue Jun 28, 2017
Merged
@trungdq88
Copy link
Contributor

@gaearon https://github.com/MoOx/eslint-loader/releases/tag/1.9.0 is released 😄

@gaearon
Copy link
Contributor Author

gaearon commented Jul 6, 2017

Nice! Want to send a PR to use it?

@trungdq88
Copy link
Contributor

I'm happy to. Will have a look tonight.

@trungdq88
Copy link
Contributor

@gaearon: #2735

My first PR, please advice.

@gaearon
Copy link
Contributor Author

gaearon commented Jul 8, 2017

Seems like this is done in #2735.
Thank you!

@gaearon gaearon closed this as completed Jul 8, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
tag: internal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaearon @trungdq88