Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow error in eslint-plugin-jsx-a11y #2663

Closed
gaearon opened this issue Jun 28, 2017 · 2 comments
Closed

Flow error in eslint-plugin-jsx-a11y #2663

gaearon opened this issue Jun 28, 2017 · 2 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented Jun 28, 2017

Users adding Flow to their project will bump into this error:

https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/249

node_modules/eslint-plugin-jsx-a11y/src/rules/media-has-caption.js:54
 54:         if (child.type !== 'JSXElement') {
                       ^^^^ property `type`. Property not found in
 54:         if (child.type !== 'JSXElement') {
                 ^^^^^ Node

This is because eslint-plugin-jsx-a11y currently intentionally ships src directory which recently got Flow annotations.

I don't know what the solution is but filed this to keep tracking.

The workaround for now would be to add this plugin to [ignore] section of .flowconfig but of course this breaks our zero-config promise.

@gaearon
Copy link
Contributor Author

gaearon commented Jan 20, 2018

I believe we fixed this in #2690.

@gaearon gaearon closed this as completed Jan 20, 2018
@penx
Copy link

penx commented Jan 24, 2018

@gaearon can eslint-config-react-app be bumped to 2.1.1 and published so we can get this fix? Is this something I can raise a PR for?

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants