Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Webpack config to single file #4030

Closed
langpavel opened this issue Feb 15, 2018 · 4 comments
Closed

Merge Webpack config to single file #4030

langpavel opened this issue Feb 15, 2018 · 4 comments
Milestone

Comments

@langpavel
Copy link

langpavel commented Feb 15, 2018

Is this a bug report?

No, it's refactoring proposal

Expected Behavior

Environment specific behavior should be configured in one single webpack.config.js file

Actual Behavior

There are two configuration files webpack.config.dev.js and webpack.config.prod.js

Why?

  • Mostly the only reason for ejecting is need to customize WebPack config file.
  • Both files must be edited in near same way. This can be source of code duplication and mistakes

How?

  • simply use config/env.js
  • use new Webpack 4 mode
@gaearon
Copy link
Contributor

gaearon commented Feb 18, 2018

I agree we'll probably want to do that after webpack 4 migration.

@andriijas andriijas mentioned this issue Feb 26, 2018
23 tasks
@stale
Copy link

stale bot commented Nov 2, 2018

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs.

@stale stale bot added the stale label Nov 2, 2018
@langpavel
Copy link
Author

I see that this is still actual. Any plans?

@stale stale bot removed the stale label Nov 2, 2018
@Timer Timer added this to the 2.x milestone Nov 2, 2018
@iansu
Copy link
Contributor

iansu commented Mar 10, 2019

This is done.

@iansu iansu closed this as completed Mar 10, 2019
@lock lock bot locked and limited conversation to collaborators Mar 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants