Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation surrounding Sass support #4334

Closed
Timer opened this issue Apr 21, 2018 · 7 comments
Closed

Add documentation surrounding Sass support #4334

Timer opened this issue Apr 21, 2018 · 7 comments

Comments

@Timer
Copy link
Contributor

Timer commented Apr 21, 2018

No description provided.

@Timer Timer added this to the 2.0.0 milestone Apr 21, 2018
@bugzpodder
Copy link

Just tried it out, works great. I don't know enough to properly document the feature, but in js I just do
import 'path/to/my.scss'
and inside a scss file I just do
@import 'path/to/my.scss'
and for node_module imports:
@import '~package/other.css'

@Timer
Copy link
Contributor Author

Timer commented Apr 21, 2018

Glad to hear it works for you -- that's what we were going for! 😃 Something that should "just work".

@adamwright104
Copy link

This is working for me. followed the install and changed the app.css and index.css to be scss and no styles show

@bradfordlemley
Copy link
Contributor

Specifically, adding-a-css-preprocessor-sass-less-etc section in User Guide should be updated.

Note: node-sass needs to be included separately in app's devDependencies (intentional, as requested by CRA.)

@Timer Timer modified the milestones: 2.0.x, 2.x Sep 26, 2018
@mareksuscak
Copy link
Contributor

mareksuscak commented Sep 27, 2018

This may have been resolved in d7bffca#diff-4e6ec56f74ee42069aac401a4fe448ad

EDIT: although there's one thing that's not documented properly - *.module.scss - it relates to both SCSS and CSS modules section of the doc (reference)

@Timer
Copy link
Contributor Author

Timer commented Sep 27, 2018

Feel free to send PR update, @mareksuscak!

@mareksuscak
Copy link
Contributor

mareksuscak commented Sep 27, 2018

@Timer done and linked to this issue. Here's a preview.

@Timer Timer closed this as completed Sep 27, 2018
@Timer Timer modified the milestones: 2.x, 2.0.0 Sep 27, 2018
@lock lock bot locked and limited conversation to collaborators Jan 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants