Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look again at browser defaults #4355

Closed
gaearon opened this issue Apr 24, 2018 · 3 comments
Closed

Look again at browser defaults #4355

gaearon opened this issue Apr 24, 2018 · 3 comments
Milestone

Comments

@gaearon
Copy link
Contributor

gaearon commented Apr 24, 2018

Not sure what we have there now but just leaving this for another look closer to 2.x
https://mobile.twitter.com/jamiebuilds/status/988559577313492992

@gaearon gaearon added this to the 2.0.0 milestone Apr 24, 2018
@Timer
Copy link
Contributor

Timer commented Apr 24, 2018

const defaultBrowsers = {
development: ['chrome', 'firefox', 'edge'].map(
browser => `last 2 ${browser} versions`
),
production: ['>1%', 'last 4 versions', 'Firefox ESR', 'not ie < 11'],
};

We use the "last 2 versions" of modern browsers for dev so I think we're safe there, I think this generic rule (in the tweet) includes iOS/Android browser/IE which causes you to support "old browsers".

The "production" browser support is matching to what we supported in v1, so we could talk about modernizing that.

Our production match evaluates to:
image

I imagine we'd want to exclude [most] of those mobile browsers by default.

@ngbrown
Copy link
Contributor

ngbrown commented May 13, 2018

Evidently, the googlebot crawler is on Chrome v41 so there's that for sites which expect to be indexed. Supporting IE11 is probably keeping the output compatible for now.

@Timer
Copy link
Contributor

Timer commented May 24, 2018

Landed #4470 as a start, we can refine this more.

@Timer Timer closed this as completed Sep 26, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants