Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WatchMissingNodeModulesPlugin.apply typecasting issue #4366

Closed
krazyjakee opened this issue Apr 26, 2018 · 3 comments
Closed

WatchMissingNodeModulesPlugin.apply typecasting issue #4366

krazyjakee opened this issue Apr 26, 2018 · 3 comments

Comments

@krazyjakee
Copy link

krazyjakee commented Apr 26, 2018

Is this a bug report?

Yes this is a bug because WatchMissingNodeModulesPlugin.apply has a typecasting issue.

Did you try recovering your dependencies?

Yes.

Which terms did you search for in User Guide?

I looked for known issues with missingDeps.some and WatchMissingNodeModulesPlugin.

Environment

  1. react-dev-utils@next
  2. node -v: v10.0.0
  3. npm -v: 6.0.0
  4. webpack: 4.6.0
  5. npm ls react-scripts (if you haven’t ejected):
create-react-library@1.1.0 /Users/jacobcattrall/GitHub/create-react-library
└── (empty)
  1. Operating system: OSX

Steps to Reproduce

  1. Require the plugin const WatchMissingNodeModulesPlugin = require('react-dev-utils/WatchMissingNodeModulesPlugin');
  2. Add new WatchMissingNodeModulesPlugin() to the plugin section of your webpack.config.js.
  3. Run the project.

Expected Behavior

Logic would work with the delivered type (Set).

Actual Behavior

Webpack crashes with missingDeps.some is not a function error.

The crash happens at this particular line: https://github.com/facebook/create-react-app/blob/next/packages/react-dev-utils/WatchMissingNodeModulesPlugin.js#L25

missingDeps is a Set

I cannot seem to find documentation on there being a Set.prototype.some function. I wonder if compilation.missingDependencies is supposed to be an array? If so, I simply cannot follow how it became a Set. Can anyone point me in the right direction to debug/fix this issue?

Reproducible Demo

git clone git@github.com:krazyjakee/create-react-library.git
npm i
npm run start
@andriijas
Copy link
Contributor

Thanks. Its fixed in #4077

What we could do is to break out dev tools to seperate PR

@krazyjakee
Copy link
Author

@andriijas shall I do it?

@krazyjakee
Copy link
Author

lol nevermind, I tried but it ties in with way too many other changes around the project. It's a headspace I am so far from right now that by the time I resolved it, your main pull request would be merged.

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants