-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WatchMissingNodeModulesPlugin.apply typecasting issue #4366
Comments
This was referenced Apr 26, 2018
Merged
Thanks. Its fixed in #4077 What we could do is to break out dev tools to seperate PR |
@andriijas shall I do it? |
lol nevermind, I tried but it ties in with way too many other changes around the project. It's a headspace I am so far from right now that by the time I resolved it, your main pull request would be merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is this a bug report?
Yes this is a bug because WatchMissingNodeModulesPlugin.apply has a typecasting issue.
Did you try recovering your dependencies?
Yes.
Which terms did you search for in User Guide?
I looked for known issues with
missingDeps.some
andWatchMissingNodeModulesPlugin
.Environment
react-dev-utils@next
node -v
: v10.0.0npm -v
: 6.0.0webpack
: 4.6.0npm ls react-scripts
(if you haven’t ejected):Steps to Reproduce
const WatchMissingNodeModulesPlugin = require('react-dev-utils/WatchMissingNodeModulesPlugin');
new WatchMissingNodeModulesPlugin()
to the plugin section of your webpack.config.js.Expected Behavior
Logic would work with the delivered type (Set).
Actual Behavior
Webpack crashes with
missingDeps.some is not a function
error.The crash happens at this particular line: https://github.com/facebook/create-react-app/blob/next/packages/react-dev-utils/WatchMissingNodeModulesPlugin.js#L25
missingDeps is a Set
I cannot seem to find documentation on there being a
Set.prototype.some
function. I wonder ifcompilation.missingDependencies
is supposed to be an array? If so, I simply cannot follow how it became a Set. Can anyone point me in the right direction to debug/fix this issue?Reproducible Demo
The text was updated successfully, but these errors were encountered: