Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--scripts-version=@package referencing tag, not package. Is this intentional behavior? #4666

Closed
brunolm opened this issue Jun 23, 2018 · 5 comments

Comments

@brunolm
Copy link

brunolm commented Jun 23, 2018

create-react-app@2.0.0-next.3e165448 is having problems when the package name starts with @

create-react-app cra-ts --scripts-version="@petejkim/react-scripts-ts-sass" --use-npm

it tries to install react-scripts@...

Aborting installation.
npm install --save --save-exact --loglevel error react react-dom react-scripts@petejkim/react-scripts-ts-sass has failed.

create-react-app@1.5.2 has no issues

Installing react, react-dom, and @petejkim/react-scripts-ts-sass...

@bugzpodder
Copy link

I can repo this. Definitely seem like a bug.

@miraage
Copy link

miraage commented Jun 25, 2018

Could da4a87f break it?

@miraage
Copy link

miraage commented Jun 25, 2018

I knew it might backfire #4348 (comment)

@Timer I think I can open a PR to fix that.

@Timer
Copy link
Contributor

Timer commented Jun 25, 2018

This is def a bug. A PR to make the following behavior work would be great:

--scripts-version=@next # treated as tag
--scripts-version=@bla/foo # treated as package

@Timer
Copy link
Contributor

Timer commented Jun 25, 2018

Oop, looks like fix is up in #4677.

@Timer Timer closed this as completed Jun 25, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants