Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No documentation about git init #5291

Closed
ryancogswell opened this issue Oct 4, 2018 · 5 comments
Closed

No documentation about git init #5291

ryancogswell opened this issue Oct 4, 2018 · 5 comments

Comments

@ryancogswell
Copy link
Contributor

I was surprised when trying out create-react-app 2 that the new app I created had its own git repository. I didn't see any mention of this in the user guide or in the "what's new" portion of the blog post. Eventually I found the code changes from @mauricedb for issue #1288. I don't have a problem with the new behavior, but it should be documented somewhere.

@gaearon
Copy link
Contributor

gaearon commented Oct 4, 2018

Happy to take a PR. Not sure what would be the best place to document it.

@ryancogswell
Copy link
Contributor Author

Perhaps an addition to the "Folder Structure" portion of the user guide:
If you have Git installed and your project is not part of a larger repository, then a new repository will be initialized resulting in an additional ".git/" top-level directory.

@Timer
Copy link
Contributor

Timer commented Oct 4, 2018

That sounds good. Send a pull request?

@mauricedb
Copy link
Contributor

Hi @ryancogswell,

Feel free to do this if you. If not I am happy to add it as well.

Maurice

@ryancogswell
Copy link
Contributor Author

I'll give it a go. I haven't ever done a pull request on github before, but I couldn't have a simpler case to work through for my first time.

@Timer Timer closed this as completed Oct 5, 2018
@lock lock bot locked and limited conversation to collaborators Jan 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants