Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript serviceWorker.register() types fails out of the box because of required config parameter #5650

Closed
eddedd88 opened this issue Oct 31, 2018 · 0 comments · Fixed by #5651
Closed

Typescript serviceWorker.register() types fails out of the box because of required config parameter #5650

eddedd88 opened this issue Oct 31, 2018 · 0 comments · Fixed by #5651

Comments

@eddedd88
Copy link
Contributor

Environment

Typescript

Steps to Reproduce

  1. Start an app with typescript: create-react-app --typescript test-app
  2. Enable PWA by following the steps here: https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app
  3. The method serviceWorker.register() works fine in js, but in typescript the config argument is mandatory which causes the build to fail.
@eddedd88 eddedd88 mentioned this issue Oct 31, 2018
Merged
@lock lock bot locked and limited conversation to collaborators Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make serviceWorker config argument optional in typescript eddedd88/create-react-app
1 participant
@eddedd88